RFR: 8329726: Use non-short forward jumps in lightweight locking [v3]
Axel Boldt-Christmas
aboldtch at openjdk.org
Mon Apr 8 08:44:10 UTC 2024
On Mon, 8 Apr 2024 08:19:32 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> This turns a few short-jumps to long-jumps in x86 lightweight locking code paths. When running with -XX:+ShowMessageBoxOnError, MA::stop() generates more code and jccb is not sufficient to address this.
>>
>> Two of the jccb are in ASSERT path anyway. However, another is also in a product path. We *could* generate jccb or jcc conditionally on ShowMessageBoxOnError, however, I don't think it is worth the trouble. WDYT?
>>
>> Unfortunately, I could not make a simple test-case, because ShowMessageBoxOnError stops and waits on error, which would make jtreg time-out.
>>
>> Testing:
>> - [x] manual test with dacapo as provided in the bug report
>> - [ ] tier1
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>
> Add test-case
lgtm.
-------------
Marked as reviewed by aboldtch (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18657#pullrequestreview-1985801663
More information about the hotspot-compiler-dev
mailing list