RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v15]

Joshua Cao duke at openjdk.org
Mon Apr 8 18:42:46 UTC 2024


On Mon, 8 Apr 2024 06:32:02 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Joshua Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 24 additional commits since the last revision:
>> 
>>  - Fix typo
>>  - Formatting, use @run driver, remove legacy header comments
>>  - Merge remote-tracking branch 'josh/licm' into licm
>>  - Merge branch 'master' into licm
>>  - @run driver -> @run main
>>  - Add tests for add/sub reassociation
>>  - Merge branch 'master' into licm
>>  - Merge branch 'master' into licm
>>  - Merge branch 'master' into licm
>>  - Merge branch 'master' into licm
>>  - ... and 14 more: https://git.openjdk.org/jdk/compare/6bf3451d...1b27aae4
>
> src/hotspot/share/opto/loopTransform.cpp line 277:
> 
>> 275:   }
>> 276:   for (DUIterator i = n->outs(); n->has_out(i); i++) {
>> 277:     BoolNode *bool_out = n->out(i)->isa_Bool();
> 
> Suggestion:
> 
>     BoolNode* bool_out = n->out(i)->isa_Bool();

Thanks, committed suggestion through GitHub

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17375#discussion_r1556262849


More information about the hotspot-compiler-dev mailing list