RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v10]

Hamlin Li mli at openjdk.org
Tue Apr 9 08:43:30 UTC 2024


On Tue, 9 Apr 2024 08:09:51 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use java library code of Math.round as golden value
>
> test/hotspot/jtreg/compiler/vectorization/TestRoundVectorFloatRandom.java line 64:
> 
>> 62: 
>> 63:   int golden_round(float a) {
>> 64:     // below code is copied from java.base/share/classes/java/lang/Math.java
> 
> Suggestion:
> 
>   static int golden_round(float a) {
>     // below code is copied from java.base/share/classes/java/lang/Math.java

Thanks for the suggestion, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1557228307


More information about the hotspot-compiler-dev mailing list