RFR: 8328614: hsdis: dlsym can't find decode symbol [v3]

Hamlin Li mli at openjdk.org
Tue Apr 9 10:09:11 UTC 2024


On Fri, 5 Apr 2024 10:45:24 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols.
>> Tested with gcc and clang, and llvm and binutils backend.
>> 
>> I didn't find any use of the "DLL_ENTRY", so I removed it.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use JNIEXPORT

Looks good.
Although I'm not the right person to review this, thanks for explanation and discussion.

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18400#pullrequestreview-1988652730


More information about the hotspot-compiler-dev mailing list