Integrated: 8329726: Use non-short forward jumps in lightweight locking
Roman Kennke
rkennke at openjdk.org
Tue Apr 9 14:53:15 UTC 2024
On Fri, 5 Apr 2024 13:33:33 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
> This turns a few short-jumps to long-jumps in x86 lightweight locking code paths. When running with -XX:+ShowMessageBoxOnError, MA::stop() generates more code and jccb is not sufficient to address this.
>
> Two of the jccb are in ASSERT path anyway. However, another is also in a product path. We *could* generate jccb or jcc conditionally on ShowMessageBoxOnError, however, I don't think it is worth the trouble. WDYT?
>
> Unfortunately, I could not make a simple test-case, because ShowMessageBoxOnError stops and waits on error, which would make jtreg time-out.
>
> Testing:
> - [x] manual test with dacapo as provided in the bug report
> - [ ] tier1
This pull request has now been integrated.
Changeset: 2e925f26
Author: Roman Kennke <rkennke at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2e925f263d5a9a69f21e0c12bd71242fdff084cd
Stats: 45 lines in 2 files changed: 41 ins; 0 del; 4 mod
8329726: Use non-short forward jumps in lightweight locking
Reviewed-by: shade, kvn, aboldtch
-------------
PR: https://git.openjdk.org/jdk/pull/18657
More information about the hotspot-compiler-dev
mailing list