RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v9]
Hamlin Li
mli at openjdk.org
Wed Apr 10 18:44:12 UTC 2024
On Wed, 10 Apr 2024 17:18:00 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Yes, I see. The `@Run` annotation runs it all with the IR framework, which you don't really need for an exhaustive test over the 32-bit range.
>>
>> I think I may have been rather misled by the "Add exhaustive tests for Math.round intrinsics" title, which this PR doesn't do. I strongly suggest that you do add an exhaustive test for the 32-bit range, without using the `@Run` annotation, just the bare code.
>
> And my test only works on the scalar version, of course.
Do you mean add an exhaustive test for the 32-bit range for the vector instrinsic or scalar one?
The only issue I have for an exhaustive test for the 32-bit range is that it takes too long time to be an automatic test, and we don't want to add an manual test as it seldomly runs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1559908931
More information about the hotspot-compiler-dev
mailing list