RFR: 8329258: [AArch64] TailCall should not use frame pointer register for jump target [v2]
Tobias Hartmann
thartmann at openjdk.org
Thu Apr 11 05:14:57 UTC 2024
On Wed, 10 Apr 2024 16:25:37 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adjusted comments according to review
>
> src/hotspot/cpu/aarch64/aarch64.ad line 16193:
>
>> 16191: // TailJump below removes the return address.
>> 16192: // Don't use rfp for the jump_target because the
>> 16193: // MachEpilogNode that is inserted above will kill it.
>
> This is a somewhat opaque comment. Please say that a `MachEpilogNode` has already been emitted, so the current rfp contains a value that belongs to the caller of this method, so it must not be used.
Thanks Andrew. I adjusted the comments, please let me know what you think.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18716#discussion_r1560442288
More information about the hotspot-compiler-dev
mailing list