RFR: 8329258: TailCall should not use frame pointer register for jump target [v2]

Tobias Hartmann thartmann at openjdk.org
Thu Apr 11 07:07:27 UTC 2024


On Thu, 11 Apr 2024 06:43:46 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjusted comments according to review
>
> src/hotspot/cpu/aarch64/aarch64.ad line 16193:
> 
>> 16191: // TailJump below removes the return address.
>> 16192: // Don't use rfp for 'jump_target' because a MachEpilogNode has already been
>> 16193: // emitted just above the TailCall and it will reset rbp to the caller state.
> 
> Suggestion: s/rbp/rfp/

Good catch! Will fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18716#discussion_r1560518406


More information about the hotspot-compiler-dev mailing list