RFR: 8329258: TailCall should not use frame pointer register for jump target [v3]
Tobias Hartmann
thartmann at openjdk.org
Thu Apr 11 10:31:10 UTC 2024
On Thu, 11 Apr 2024 08:26:34 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added RISCV patch and fixed comment
>
> src/hotspot/cpu/aarch64/aarch64.ad line 16193:
>
>> 16191: // TailJump below removes the return address.
>> 16192: // Don't use rfp for 'jump_target' because a MachEpilogNode has already been
>> 16193: // emitted just above the TailCall and it will reset rfp to the caller state.
>
> Suggestion:
>
> // emitted just above the TailCall which has reset rfp to the caller state.
Thanks. I updated the comments accordingly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18716#discussion_r1560793987
More information about the hotspot-compiler-dev
mailing list