RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v9]

Hamlin Li mli at openjdk.org
Thu Apr 11 10:49:45 UTC 2024


On Wed, 10 Apr 2024 20:20:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Do you mean add an exhaustive test for the 32-bit range for the vector instrinsic or scalar one?
>> The only issue I have for an exhaustive test for the 32-bit range is that it takes too long time to be an automatic test, and we don't want to add an manual test as it seldomly runs.
>
>> The only issue I have for an exhaustive test for the 32-bit range is that it takes too long time to be an automatic test, and we don't want to add an manual test as it seldomly runs.
> 
> But it takes a long time because you use the @Run attribute, surely. If you ran that test just as a test, without the IR framework, it'd be fine.

Yes, you mght be right.
But previously @eme64 asked to change from a plain test to a test using IR framework.

So I'm not sure what to do now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1560813613


More information about the hotspot-compiler-dev mailing list