RFR: 8324950: IGV: save the state to a file [v20]

Tobias Holenstein tholenstein at openjdk.org
Thu Apr 11 13:40:45 UTC 2024


On Thu, 11 Apr 2024 08:33:58 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> One issue with that is that now graphs are opened with a fixed set of visible nodes rather than "all nodes are visible". This works for the graph that is directly shown when the file is open, but if you step into the next graph in the group, new nodes will be hidden. To reproduce this, you can open [one-graph.zip](https://github.com/openjdk/jdk/files/14943396/one-graph.zip) and click on "Show next graph of current group". In the next graph, nodes 5, 7, 25, 26, and 27 are hidden unexpectedly.

I opted for your proposal introducing an attribute that indicates if all nodes should be visible:

- Show all nodes an ignore nodes in <visibleNodes> (should be empty anyways)

<visibleNodes all="true">
</visibleNodes>


- Show no nodes

<visibleNodes all="false">
</visibleNodes>


- Show only nodes "0"

<visibleNodes all="false">
<node id="0"/>
</visibleNodes>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17630#issuecomment-2049714393


More information about the hotspot-compiler-dev mailing list