RFR: 8325520: Vector loads with offsets incorrectly compiled

[Emanuel Peter]

On Wed, 27 Mar 2024 08:43:41 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorapi/VectorGatherMaskFoldingTest.java line 43:
>> 
>>> 41:  * @modules jdk.incubator.vector
>>> 42:  *
>>> 43:  * @run main/othervm -XX:UseAVX=3 compiler.vectorapi.VectorLoadGatherFoldingTest
>> 
>> I would also make sure that you don't require platform specific things here. This could also run on any other platform that supports the Vector API, right? And you will need at least one run without any flags.
>
> You're right. I've relaxed the require (the max vector size shouldn't be relevant) and added `sve`. I'm not sure if there is a way to make it more generic (all platforms that support vectors?).

Do you even need to restrict the test to these platforms, or is it ok to run the tests on any platform?
Because the Vector API can be used on any platform, we may just use scalar operation instead. But that needs to be tested as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1540688549