RFR: 8329194: Cleanup Type::cmp definition and usage [v2]

[Jasmine Karthikeyan]

> Hi all, this patch aims to cleanup `Type::cmp` by changing it from returning a `0` when types are equal and `1` when they are not, to it returning a boolean denoting equality. This makes its usages at various callsites more intuitive. However, as it is passed to the type dictionary as a comparator, a lambda is needed to map the boolean to a comparison value. 
> 
> I was also considering changing the name to `Type::equals` as it's not really returning a comparison value anymore, but I felt it would be too similar to `Type::eq`. If this would be preferred though, I can change it.
> 
> Tier 1 testing passes on my machine. Reviews and thoughts would be appreciated!

Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:

  Rename to Type::equals, changes from code review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18533/files
  - new: https://git.openjdk.org/jdk/pull/18533/files/63c17d53..46a4f3fa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18533&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18533&range=00-01

  Stats: 21 lines in 9 files changed: 0 ins; 0 del; 21 mod
  Patch: https://git.openjdk.org/jdk/pull/18533.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18533/head:pull/18533

PR: https://git.openjdk.org/jdk/pull/18533