RFR: 8329194: Cleanup Type::cmp definition and usage [v2]

[Jasmine Karthikeyan]

On Mon, 15 Apr 2024 09:54:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/cpu/x86/x86.ad line 10010:
>> 
>>> 10008:     const MachNode* mask1 = static_cast<const MachNode*>(this->in(this->operand_index($src1)));
>>> 10009:     const MachNode* mask2 = static_cast<const MachNode*>(this->in(this->operand_index($src2)));
>>> 10010:     assert(Type::cmp(mask1->bottom_type(), mask2->bottom_type()), "");
>> 
>> While at it, you could add a message like "should be false" for good practice.
>
> Well, I would say it should be "types must be equal".

This is a good idea, I've made this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18533#discussion_r1566624263