RFR: 8330213: RISC-V: C2: assert(false) failed: bad AD file after JDK-8316991

Robbin Ehn rehn at openjdk.org
Tue Apr 16 10:22:02 UTC 2024


On Sun, 14 Apr 2024 07:58:48 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi, please review this fix that adds additional CMove match rules for the riscv port.
> [JDK-8316991](https://bugs.openjdk.org/browse/JDK-8316991) introduces more conditional moves which reduce merges used by CmpP/CmpN. However, there is no match rule for CMove with CmpP/N on riscv, resulting in the `bad AD file` crash.
> 
> After this fix, the following five tests would pass without any crashes.
> 
> Testing:
> - [x] compiler/eliminateAutobox/TestDoubleBoxing.java
> - [x] compiler/eliminateAutobox/TestFloatBoxing.java
> - [x] compiler/eliminateAutobox/TestLongBoxing.java
> - [x] compiler/eliminateAutobox/TestIntBoxing.java
> - [x] compiler/eliminateAutobox/TestShortBoxing.java 
> - [x] tier1~3  (linux-riscv64, release)
> - [x] hotspot:tier1 (linux-riscv64, fastdebug)

Seems fine to me.

-------------

Marked as reviewed by rehn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18774#pullrequestreview-2003228523


More information about the hotspot-compiler-dev mailing list