RFR: 8320649: C2: Optimize scoped values [v13]

[Roland Westrelin]

On Thu, 4 Apr 2024 13:34:35 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test fix
>
> src/hotspot/share/opto/type.cpp line 617:
> 
>> 615:   TypeInstKlassPtr::OBJECT_OR_NULL = TypeInstKlassPtr::make(TypePtr::BotPTR, current->env()->Object_klass(), 0);
>> 616: 
>> 617:   const Type** fgetfromcache =(const Type**)shared_type_arena->AmallocWords(3*sizeof(Type*));
> 
> Suggestion:
> 
>   const Type** fgetfromcache = (const Type**)shared_type_arena->AmallocWords(3*sizeof(Type*));

Fixed in latest commit

> src/hotspot/share/opto/type.cpp line 622:
> 
>> 620:   fgetfromcache[2] = TypeAryPtr::OOPS;
>> 621:   TypeTuple::make(3, fgetfromcache);
>> 622:   const Type** fsvgetresult =(const Type**)shared_type_arena->AmallocWords(2*sizeof(Type*));
> 
> Suggestion:
> 
>   const Type** fsvgetresult = (const Type**)shared_type_arena->AmallocWords(2*sizeof(Type*));

Fixed in latest commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1567492780
PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1567492883