RFR: 8324950: IGV: save the state to a file [v25]

Tobias Holenstein tholenstein at openjdk.org
Wed Apr 17 07:36:16 UTC 2024


On Wed, 17 Apr 2024 07:04:57 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> > Thanks for catching that! I fixed it. Difference graph are supported as long as they are in the same group. A difference graph from two different groups is just not saved to the xml.
> 
> Great, that works fine now, as far as I can see. A minor related issue is that difference graphs from two different groups are not closed when the workspace is cleared. Is this expected? I would intuitively expect them to be closed as well, but I guess one can also argue that they do not belong to the workspace.

Right. Implementation wise difference graphs from two groups are kind of a special case. But I agree the user would expect all tabs to be closed. Since we only ever have one workspace at the time, we can simply close all tabs when the workspace is closed - that's what I added in the latest commit. I think this is a good enough solution

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17630#issuecomment-2060575448


More information about the hotspot-compiler-dev mailing list