RFR: 8320649: C2: Optimize scoped values [v13]
Emanuel Peter
epeter at openjdk.org
Wed Apr 17 13:34:04 UTC 2024
On Fri, 5 Apr 2024 13:22:47 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>> And you further repeat the comments below. I fear that if someone would eventually make changes, they would not update all comments, and then the comments diverge.
>
> That one doesn't duplicate the one above `transform_get_subgraph()`. It's supposed to show what change was just made to the graph by `replace_current_exit_of_get_with_halt()`. Same for the one below, it's expected to show an incremental change. It's hard to show what changes without keeping the entire structure of the code I think.
Maybe you can have them side-by side, so it is easier to visually parse the difference?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16966#discussion_r1568851037
More information about the hotspot-compiler-dev
mailing list