RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v3]
Damon Fenacci
dfenacci at openjdk.org
Wed Apr 17 13:49:05 UTC 2024
On Tue, 26 Mar 2024 15:59:33 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>>
>> address comment.
>
> `multiply_to_len` seems to be used by `generate_squareToLen` as well for aarch64 and riscv but `zlen` is still passed in a register.
>
> https://github.com/openjdk/jdk/blob/870a6127cf54264c691f7322d775b202705c3bfa/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp#L4710
> https://github.com/openjdk/jdk/blob/870a6127cf54264c691f7322d775b202705c3bfa/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp#L2881
>
> I think it might work anyway but it might be better to adapt them if only for completeness.
> @dafedafe @dean-long please take a look and let me know if there are further issues, thanks!
Thanks @mur47x111! I noticed that you found even a few more `zlen` usages 👍
Did you test the change against all affected platforms?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18226#issuecomment-2061301421
More information about the hotspot-compiler-dev
mailing list