RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v5]
Dean Long
dlong at openjdk.org
Wed Apr 17 19:52:03 UTC 2024
On Wed, 17 Apr 2024 19:45:02 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>>
>> address comment.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4702:
>
>> 4700: const Register tmp5 = r15;
>> 4701: const Register tmp6 = r16;
>> 4702: const Register tmp7 = r17;
>
> No need for r17 or sorting tmps. Make tmp0 r3, or r6, r7, etc.
Also, I don't see why the code below saves and restores r4/r5. Maybe @theRealAph knows? Aren't all these registers killed across a runtime call?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1569427241
More information about the hotspot-compiler-dev
mailing list