RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction [v6]

Bhavana Kilambi bkilambi at openjdk.org
Thu Apr 18 08:16:05 UTC 2024


On Thu, 18 Apr 2024 08:03:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address some more review comments
>
> src/hotspot/cpu/aarch64/aarch64_vector.ad line 2858:
> 
>> 2856: // reduction addF
>> 2857: 
>> 2858: instruct reduce_non_strict_order_add2F_neon(vRegF dst, vRegF fsrc, vReg vsrc) %{
> 
> Now that you have changed the name of the method, you should also change the `format` in all of the methods.

Oh no! Sorry I missed that. Will do that right away.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1570228658


More information about the hotspot-compiler-dev mailing list