RFR: 8324950: IGV: save the state to a file [v31]

Tobias Holenstein tholenstein at openjdk.org
Thu Apr 18 12:46:30 UTC 2024


On Thu, 18 Apr 2024 07:10:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update GraphParser.java
>
> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/OutlineTopComponent.java line 130:
> 
>> 128:      * Obtain the OutlineTopComponent instance. Never call {@link #getDefault} directly!
>> 129:      */
>> 130:     public static synchronized OutlineTopComponent findInstance() {
> 
> Could this method then be private when it should never be called directly?

sure

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17630#discussion_r1570657736


More information about the hotspot-compiler-dev mailing list