RFR: 8330419: Unused code in ConnectionGraph::specialize_castpp

Fei Yang fyang at openjdk.org
Thu Apr 18 12:51:15 UTC 2024


On Thu, 18 Apr 2024 06:01:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Please review this small code cleanup change.
>> 
>> Noticed that `minus_one` local created in `ConnectionGraph::specialize_castpp` which is introduced by [JDK-8316991](https://bugs.openjdk.org/browse/JDK-8316991) is never used. I think it should be safe to remove this. Also renamed `boll` to `bol` to be consistent in naming with other places where we create a `BoolNode`.
>> 
>> Tersting: tier1 tested on linux-aarch64 (release & fastdebug)
>
> Looks good and trivial.

@chhagedorn : Thanks for taking a look!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18805#issuecomment-2063787002


More information about the hotspot-compiler-dev mailing list