RFR: 8330004: Refactor cloning down code in Split If for Template Assertion Predicates [v3]

Christian Hagedorn chagedorn at openjdk.org
Thu Apr 18 13:41:32 UTC 2024


> This is another patch split off https://github.com/openjdk/jdk/pull/16877. It refactors the "cloning down" code for Split If with Template Assertion Predicates. This mainly includes the replacement of `subgraph_has_opaque()` with a new class `TemplateAssertionPredicateExpressionNode`. More details can be found as PR comments.
> 
> #### Background
> 
> The cloning down code is required in Split If when trying to split any node up that belongs to a Template Assertion Predicate Expression (TAPE) (including the `OpaqueLoop*` nodes). We need to prevent that to avoid having any phi nodes in the TAPE which could result in failures when trying to later match and clone Template Assertion Predicates. Instead of cloning such a TAPE node up, we clone ("down") the entire TAPE.
> 
> Thanks,
> Christian

Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:

  Update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18723/files
  - new: https://git.openjdk.org/jdk/pull/18723/files/f072bae9..00fe1bb4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18723&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18723&range=01-02

  Stats: 36 lines in 2 files changed: 16 ins; 18 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18723.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18723/head:pull/18723

PR: https://git.openjdk.org/jdk/pull/18723


More information about the hotspot-compiler-dev mailing list