RFR: 8323429: Missing C2 optimization for FP min/max when both inputs are same [v3]

Christian Hagedorn chagedorn at openjdk.org
Fri Apr 19 07:28:58 UTC 2024


On Wed, 17 Apr 2024 11:08:01 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Added C2 identity optimization for min/max calls, whereby if both inputs are the same, either is returned.
>> 
>> It includes an IR test to verify that the optimization gets applied. The optimization applies not only to floating points, but also long and ints. The test includes tests for all of those.
>> 
>> `BasicDoubleOpTest.vectorMax_8322090` has also been adjusted to match expectations after implementing the optimization.
>> 
>> I've run hotspot compiler tests successfully on x86_64.
>
> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use failOn instead of counts

Yes, that looks unrelated and is most likely [JDK-8328066](https://bugs.openjdk.org/browse/JDK-8328066) which was fixed in the meantime. So, I think you can safely ignore this issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18738#issuecomment-2065933716


More information about the hotspot-compiler-dev mailing list