RFR: 8330621: Make 5 compiler tests use ProcessTools.executeProcess

Christian Hagedorn chagedorn at openjdk.org
Fri Apr 19 11:43:56 UTC 2024


On Fri, 19 Apr 2024 07:22:06 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> Said tests use simple `new ProcessBuilder` and its `start` method to start secondary processes.
> 
> As stated in [JDK-8174768](https://bugs.openjdk.org/browse/JDK-8174768), we try to have more information about started secondary processes and make the execution more controllable. This PR makes those tests use ProcessTools.executeProcess instead of using the `.start` method.

Looks good!

test/hotspot/jtreg/compiler/profiling/spectrapredefineclass_classloaders/Launcher.java line 71:

> 69:             OutputAnalyzer output = ProcessTools.executeProcess(pb);
> 70:             output.shouldHaveExitValue(0);
> 71:         } catch (IOException ex) {

Can probably also be updated as in Test7068051?
Suggestion:

        } catch (Exception ex) {

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18856#pullrequestreview-2011208159
PR Review Comment: https://git.openjdk.org/jdk/pull/18856#discussion_r1572243237


More information about the hotspot-compiler-dev mailing list