RFR: 8330621: Make 5 compiler tests use ProcessTools.executeProcess

Stefan Karlsson stefank at openjdk.org
Fri Apr 19 11:55:00 UTC 2024


On Fri, 19 Apr 2024 07:22:06 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> Said tests use simple `new ProcessBuilder` and its `start` method to start secondary processes.
> 
> As stated in [JDK-8174768](https://bugs.openjdk.org/browse/JDK-8174768), we try to have more information about started secondary processes and make the execution more controllable. This PR makes those tests use ProcessTools.executeProcess instead of using the `.start` method.

Looks good to me.

Do you know that you also could skip explicitly creating ProcessBuilders and instead run:

ProcessTools.executeProcess(jar.getCommand());

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18856#pullrequestreview-2011226615


More information about the hotspot-compiler-dev mailing list