RFR: 8329331: Intrinsify Unsafe::setMemory [v21]

Scott Gibbons sgibbons at openjdk.org
Fri Apr 19 14:58:05 UTC 2024


On Fri, 19 Apr 2024 13:25:33 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add enter() and leave(); remove Windows-specific register stuff
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2611:
> 
>> 2609:     // Propagate byte to full Register
>> 2610:     __ movzbl(rScratch1, byteVal);
>> 2611:     __ mov64(wide_value, 0x0101010101010101);
> 
> Long constant should be suffixed by ULL.

Fixed.

> test/micro/org/openjdk/bench/java/lang/foreign/MemorySegmentZeroUnsafe.java line 1:
> 
>> 1: package org.openjdk.bench.java.lang.foreign;
> 
> Copyright header missing.

Added

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1572502532
PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1572502204


More information about the hotspot-compiler-dev mailing list