RFR: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow [v4]

[Matias Saavedra Silva]

On Fri, 19 Apr 2024 09:23:56 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fei comments
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 1786:
> 
>> 1784:   add(cache, cache, Array<ResolvedFieldEntry>::base_offset_in_bytes());
>> 1785:   lea(cache, Address(cache, index));
>> 1786:   // Must prevent reordering of the following cp cache loads with bytecode load
> 
> This is rather unclear. Where is the bytecode load to which this comment refers?

This comment was above all the other uses of membar and was just moved here for convenience. The "bytecode load" being referred to here is `InterpreterMacroAssembler::dispatch_next`. The bytecode loading could be scheduled before the cache entry is resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18477#discussion_r1572580608