RFR: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow [v4]

Coleen Phillimore coleenp at openjdk.org
Fri Apr 19 20:39:31 UTC 2024


On Fri, 19 Apr 2024 18:59:40 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> This comment was above all the other uses of membar and was just moved here for convenience. The "bytecode load" being referred to here is `InterpreterMacroAssembler::dispatch_next`. The bytecode loading could be scheduled before the cache entry is resolved.
>
> The comment at the stop says "This patch adds an appropriate LoadLoad barrier after a constant pool cache field entry is loaded." But this seems to be before the constant pool cache field entry is loaded.

I think what this wants to say is that when you've loaded the pointer to the ResolvedFieldEntry in 'cache', previous memory operations have been synched before the fields in the resolved entry are read.  I'm looking for a different word than synched.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18477#discussion_r1572928003


More information about the hotspot-compiler-dev mailing list