RFR: 8329331: Intrinsify Unsafe::setMemory [v23]

Vladimir Kozlov kvn at openjdk.org
Fri Apr 19 21:11:00 UTC 2024


On Fri, 19 Apr 2024 20:54:32 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2638:
> 
>> 2636:                                L_exit, _masm);
>> 2637:     }
>> 2638:     __ jmp(L_exit);
> 
> Here is long jump to `L_exit` after `do_setmemory_atomic_loop()` call. Should this be also short jump?

Do we have additional code in debug VM wihch increase distance and requires long jump? I don't see it. Usually it something which call `__ STOP()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1572951726


More information about the hotspot-compiler-dev mailing list