RFR: 8326742: Change compiler tests without additional VM flags from @run driver to @run main

Christian Hagedorn chagedorn at openjdk.org
Mon Apr 22 09:26:28 UTC 2024


On Fri, 19 Apr 2024 06:11:15 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> The idea of the bug was to lower down the number of tests that use driver mode incorrectly. My investigation shows up that the vast majority of such tests start other processes and in fact are more of the wrappers around that processes. Most of the secondary processes are started using ProcessTools and therefore getting additional VM flags provided by user.
> 
> I found only one test that seem to use driver mode incorrectly, this PR fixes it.
> Testing: tiers1-5, linux-x64/aarch64, macosx-x64/aarch64, windows-x64, all in debug flavours.

test/hotspot/jtreg/compiler/ccp/TestShiftConvertAndNotification.java line 41:

> 39:  * @summary Test CCP notification for value update of AndL through LShiftI and
> 40:  *          ConvI2L (no flags).
> 41:  * @run main/othervm compiler.ccp.TestShiftConvertAndNotification

Can we just use `main` instead of `main/othervm`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18854#discussion_r1574430488


More information about the hotspot-compiler-dev mailing list