RFR: 8305638: Renaming and small clean-ups around predicates [v4]

[Christian Hagedorn]

On Mon, 22 Apr 2024 11:16:34 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix useful Parse Predicate marking
>
> src/hotspot/share/opto/loopPredicate.cpp line 110:
> 
>> 108:   ProjNode* uncommon_proj = parse_predicate->proj_out(false);
>> 109:   Node* uct_region = uncommon_proj->unique_ctrl_out();
>> 110:   assert(uct_region->is_Region() || uct_region->is_Call(), "must be a region or call uct");
> 
> Did you want to remove this assert? Or is it elsewhere now?

It's already covered in `ParsePredicate::uncommon_trap()`:
https://github.com/openjdk/jdk/blob/3e185c70feef3febf75c58a5d4d394a4b772105f/src/hotspot/share/opto/ifnode.cpp#L2149-L2154

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16877#discussion_r1574594167