RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v11]

Hamlin Li mli at openjdk.org
Mon Apr 22 15:07:30 UTC 2024


On Tue, 9 Apr 2024 08:43:30 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> HI,
>> Can you have a look at this patch adding some tests for Math.round instrinsics?
>> Thanks!
>> 
>> ### FYI:
>> During the development of RoundVF/RoundF, we faced the issues which were only spotted by running test exhaustively against 32/64 bits range of int/long.
>> It's helpful to add these exhaustive tests in jdk for future possible usage, rather than build it everytime when needed.
>> Of course, we need to put it in `manual` mode, so it's not run when `-automatic` jtreg option is specified which I guess is the mode CI used, please correct me if I'm assume incorrectly.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make methods static

Seems we have no different opinions on test of Double?
Maybe it's good to push Double test first if you don't object? @eme64 @theRealAph

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17753#issuecomment-2069802619


More information about the hotspot-compiler-dev mailing list