RFR: 8330821: Rename UnsafeCopyMemory [v2]
Scott Gibbons
sgibbons at openjdk.org
Mon Apr 22 18:23:40 UTC 2024
On Mon, 22 Apr 2024 18:09:14 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comment
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1524:
>
>> 1522: // UnsafeMemoryAccess page error: continue after ucm
>> 1523: bool add_entry = !is_oop && (!aligned || sizeof(jlong) == size);
>> 1524: UnsafeMemoryAccessMark ucmm(this, add_entry, true);
>
> May be rename `ucmm` and other related locals too to avoid confusion. Word `ucm` in comments too.
Done. Comment says `unsafe access` instead of `ucm` and `umam` instead of `ucmm`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18889#discussion_r1575191505
More information about the hotspot-compiler-dev
mailing list