RFR: 8330821: Rename UnsafeCopyMemory [v2]

Sandhya Viswanathan sviswanathan at openjdk.org
Mon Apr 22 18:37:34 UTC 2024


On Mon, 22 Apr 2024 18:23:40 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> Renaming UnsafeCopyMemory to UnsafeMemoryAccess since this class is now being used for Unsafe::setMemory.  This is a pure rename only.
>
> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comment

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 1627:

> 1625:   {
> 1626:     // Add set memory mark to protect against unsafe accesses faulting
> 1627:     UnsafeMemoryAccessMark usmm(this, ((t == T_BYTE) && !aligned), true);

usmm -> umam to be consistent.

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2631:

> 2629:     {
> 2630:       Label L_wordsTail, L_wordsLoop, L_wordsTailLoop;
> 2631:       UnsafeMemoryAccessMark usmm(this, true, true);

usmm -> umam

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2645:

> 2643:     {
> 2644:       Label L_qwordLoop, L_qwordsTail, L_qwordsTailLoop;
> 2645:       UnsafeMemoryAccessMark usmm(this, true, true);

usmm -> umam

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2662:

> 2660:     {
> 2661:       Label L_dwordLoop, L_dwordsTail, L_dwordsTailLoop;
> 2662:       UnsafeMemoryAccessMark usmm(this, true, true);

usmm -> umam

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18889#discussion_r1575205497
PR Review Comment: https://git.openjdk.org/jdk/pull/18889#discussion_r1575205741
PR Review Comment: https://git.openjdk.org/jdk/pull/18889#discussion_r1575205908
PR Review Comment: https://git.openjdk.org/jdk/pull/18889#discussion_r1575205988


More information about the hotspot-compiler-dev mailing list