RFR: 8330844: Add aliases for conditional jumps and additional instruction forms for x86 [v2]
Vladimir Kozlov
kvn at openjdk.org
Mon Apr 22 21:55:28 UTC 2024
On Mon, 22 Apr 2024 21:42:27 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:
> A large part of this PR was to lessen the burden of reviewing JDK-8320448 changes. Am I hearing you say that this approach is not desired? The other PR is a big review and I was hoping to piecemeal some non-core algorithm changes in to make the review easier.
>
> It is, of course, trivial to revert the change to arrays_equals. Please let me know your final decision. Thanks.
I am for splitting big PRs if possible. And you are not limited how many self-containing sub-PRs you can create.
But each PR should address one issue for easy review and testing.
I consider this PR should address what in its title: aliases for jump instructions and adding missing cmp/jump instructions (which is related).
Any changes to not related code, like arrays_equals, do not belong here. It could be separate sub-PR or even followup PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18893#issuecomment-2071014632
More information about the hotspot-compiler-dev
mailing list