RFR: 8330625: Compilation memory statistic: prevent tearing of the final report [v2]

[Thomas Stuefe]

On Mon, 22 Apr 2024 18:01:15 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Good.
>

Thank you, Vladimir 

> What kind of testing you do for changes in this code?

Beside the GHAs, I added report printing at random intervals (so, not at shutdown) and saw with my patch a much reduced rate of tearing. The remaining tears come from the fact that the log line https://github.com/openjdk/jdk/blob/58bf813f3d60fe7bde734df68c64dbf12be01250/src/hotspot/share/compiler/compilationMemoryStatistic.cpp#L434 is printed outside the log scope still, so if report printing commences exactly at this point ( https://github.com/openjdk/jdk/blob/58bf813f3d60fe7bde734df68c64dbf12be01250/src/hotspot/share/compiler/compilationMemoryStatistic.cpp#L430), we still see the log line in middle of the report. I don't want to move the compiler log line into lock scope however since I don't want compiler threads to wait for each other after compilation. I also did not want to overcomplicate the patch.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18866#issuecomment-2071443141