RFR: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays [v10]

[Galder Zamarreño]

On Fri, 19 Apr 2024 05:38:34 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

> ```
> $ make test TEST="hotspot_compiler" JTREG="JAVA_OPTIONS=-XX:TieredStopAtLevel=1"
> ...
>    TEST                                              TOTAL  PASS  FAIL ERROR
>    jtreg:test/hotspot/jtreg:hotspot_compiler          1234  1234     0     0
> ```
> 
> 1234 tests does not seem to be enough for a low-level feature. I would also check :hotspot_gc :hotspot_serviceability :hotspot_runtime and jdk tier1-3 targets.

Fair point. I went ahead and run the following tests on linux/x64:


$ make test TEST="hotspot_compiler hotspot_gc hotspot_serviceability hotspot_runtime tier1 tier2 tier3" JTREG="JAVA_OPTIONS=-XX:TieredStopAtLevel=1 -Xcomp"


And got some failures:


==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg:hotspot_compiler          1247  1247     0     0
   jtreg:test/hotspot/jtreg:hotspot_gc                 512   512     0     0
   jtreg:test/hotspot/jtreg:hotspot_serviceability     340   340     0     0
   jtreg:test/hotspot/jtreg:hotspot_runtime            793   793     0     0
   jtreg:test/hotspot/jtreg:tier1                     2050  2050     0     0
>> jtreg:test/jdk:tier1                               2369  2368     1     0 <<
   jtreg:test/langtools:tier1                         4477  4477     0     0
   jtreg:test/jaxp:tier1                                 0     0     0     0
   jtreg:test/lib-test:tier1                            33    33     0     0
   jtreg:test/hotspot/jtreg:tier2                      649   649     0     0
>> jtreg:test/jdk:tier2                               4100  4098     1     1 <<
>> jtreg:test/langtools:tier2                           11    10     1     0 <<
   jtreg:test/jaxp:tier2                               515   515     0     0
   jtreg:test/hotspot/jtreg:tier3                      245   245     0     0
>> jtreg:test/jdk:tier3                               1413  1406     4     3 <<
   jtreg:test/langtools:tier3                            0     0     0     0
   jtreg:test/jaxp:tier3                                 0     0     0     0
==============================
TEST FAILURE


On closer inspection, the tests that failed are:


jtreg:test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java
jtreg:test/jdk/java/security/AccessController/DoPrivAccompliceTest.java
jtreg:test/langtools/jdk/jshell/FailOverDirectExecutionControlTest.java
jtreg:test/jdk/java/rmi/server/RemoteServer/AddrInUse.java
jtreg:test/jdk/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/TCPEndpointReadBug.java
jtreg:test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceParallelGCAllocationPendingStackTrace.java
jtreg:test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceSerialGCAllocationPendingStackTrace.java


I tried with the commit before my changes (https://github.com/openjdk/jdk/commit/eebcc218) and the tests also fail there when run with `JTREG="JAVA_OPTIONS=-XX:TieredStopAtLevel=1 -Xcomp"`

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17667#issuecomment-2071741244