RFR: 8305638: Renaming and small clean-ups around predicates [v5]

Christian Hagedorn chagedorn at openjdk.org
Tue Apr 23 13:48:57 UTC 2024


On Fri, 22 Dec 2023 15:02:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix useful Template Assertion Predicate marking
>
> src/hotspot/share/opto/loopnode.cpp line 4353:
> 
>> 4351:   // Initialize Dominators.
>> 4352:   // Checked in clone_loop_predicate() during beautify_loops().
>> 4353:   _idom_size = 0;
> 
> looks like a bug-fix?

Is now required due to changing `can_apply_loop_predication()` which is checked before calling this method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16877#discussion_r1576293173


More information about the hotspot-compiler-dev mailing list