RFR: 8330844: Add aliases for conditional jumps and additional instruction forms for x86 [v3]

[Emanuel Peter]

On Mon, 22 Apr 2024 22:10:56 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> Adding infrastructure for JDK-8320448.  Aliasing conditional jump instructions; adding some x86 instructions.
>
> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert changes to arrays_equals

Looks reasonable. Can you apply the indentation issue, please?

src/hotspot/cpu/x86/macroAssembler_x86.hpp line 992:

> 990: // * No condition for this *  void ALWAYSINLINE jecxz(Label& L, bool maybe_short = true) { jcc(Assembler::cxz, L, maybe_short); }
> 991: 
> 992: // Short versions of the above

Suggestion:

  // * No condition for this *  void ALWAYSINLINE jcxz(Label& L, bool maybe_short = true) { jcc(Assembler::cxz, L, maybe_short); }
  // * No condition for this *  void ALWAYSINLINE jecxz(Label& L, bool maybe_short = true) { jcc(Assembler::cxz, L, maybe_short); }

  // Short versions of the above

src/hotspot/cpu/x86/macroAssembler_x86.hpp line 1024:

> 1022:   void ALWAYSINLINE jpo_b(Label& L) { jccb(Assembler::noParity, L); }
> 1023: // * No condition for this *  void ALWAYSINLINE jcxz_b(Label& L) { jccb(Assembler::cxz, L); }
> 1024: // * No condition for this *  void ALWAYSINLINE jecxz_b(Label& L) { jccb(Assembler::cxz, L); }

Suggestion:

  // * No condition for this *  void ALWAYSINLINE jcxz_b(Label& L) { jccb(Assembler::cxz, L); }
  // * No condition for this *  void ALWAYSINLINE jecxz_b(Label& L) { jccb(Assembler::cxz, L); }

-------------

Marked as reviewed by epeter (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18893#pullrequestreview-2017688168
PR Review Comment: https://git.openjdk.org/jdk/pull/18893#discussion_r1576516938
PR Review Comment: https://git.openjdk.org/jdk/pull/18893#discussion_r1576517298