RFR: 8330181: Move PcDesc cache from nmethod header

[Vladimir Kozlov]

On Tue, 23 Apr 2024 03:59:10 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Thank you, @dean-long, for pointing this. 
>> 
>> [JDK-8302736](https://bugs.openjdk.org/browse/JDK-8302736) added 2 ThreadWXEnable in sharedRuntime.cpp
>> And later [JDK-8316392](https://bugs.openjdk.org/browse/JDK-8316392) added it to `PcDescCache::add_pc_desc()`
>> What a mess ...
>> 
>> We can now safely remove (after testing) all ThreadWXEnable which guards calls to `add_pc_desc()`
>> And file separate RFE for runtime to look on `!Thread::current_in_asgct()`
>> 
>> Is this what you are suggesting? I will do it.
>
> ASGCT code was added by [JDK-8304725](https://github.com/openjdk/jdk/commit/d8af7a6014055295355a1242db6c2872299c6398) before [JDK-8316392](https://bugs.openjdk.org/browse/JDK-8316392) added ThreadWXEnable to PcDescCache::add_pc_desc().
> 
> As you suggested I will file follow up RFE to remove that code.

RFE: https://bugs.openjdk.org/browse/JDK-8331012

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18895#discussion_r1576846664