RFR: 8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512) [v2]

[Martin Balao]

On Tue, 23 Apr 2024 23:55:24 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Avoid register conflict in Windows.
>>   
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>>   Co-authored-by: Martin Balao <mbalao at redhat.com>
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 2184:
> 
>> 2182:   const Register rounds = rax;
>> 2183:   const Register pos = r12;
>> 2184:   const Register tail = r13;
> 
> Better to use tail = r15 here. It looks to me that using tail as r13 will cause problems on Windows platform. used_addr is set as r13 in generate_counterMode_VectorAESCrypt() (line 398) for Windows platform and is needed at line 2655 so there is a conflict if we overwrite r13 as tail.

Good point. I'll change to `r15` then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18849#discussion_r1577043157