RFR: 8330181: Move PcDesc cache from nmethod header [v2]

Vladimir Kozlov kvn at openjdk.org
Wed Apr 24 18:34:29 UTC 2024


On Wed, 24 Apr 2024 15:33:42 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Currently PcDescCache (32 bytes in 64-bit VM: PcDesc* _pc_descs[4]) is allocated in `nmethod` header.
>> 
>> Moved PcDescContainer (which includes cache) to C heap similar to ExceptionCache to reduce size of `nmethod` header and to remove WXWrite transition when we update the cache in `PcDescCache::add_pc_desc()`.
>> 
>> Removed `PcDescSearch` class which was leftover from `CompiledMethod` days.
>> 
>> Tested tier1-4,stress,xcomp and performance.
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unneeded ThreadWXEnable

GHA failure is again failing upload results when tests passed:

2024-04-24T16:27:18.1181315Z    TEST                                    TOTAL  PASS  FAIL ERROR   
2024-04-24T16:27:18.1182310Z    jtreg:test/hotspot/jtreg:tier1_gc         366   366     0     0   


2024-04-24T16:28:14.1398632Z ##[error]Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18895#issuecomment-2075578454


More information about the hotspot-compiler-dev mailing list