RFR: 8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512) [v2]
Charles Connell
duke at openjdk.org
Wed Apr 24 21:17:33 UTC 2024
On Wed, 24 Apr 2024 00:36:45 GMT, Martin Balao <mbalao at openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Avoid register conflict in Windows.
>>
>> Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>> Co-authored-by: Martin Balao <mbalao at redhat.com>
>
> We changed to `r15` the register used for the tail, so we avoid conflicts in Windows.
>
> Code generated:
>
> 0x7fffe4730bb2: test $0x8,%r8b
> 0x7fffe4730bb6: je 0x7fffe4730bd3
> 0x7fffe4730bbc: vpextrq $0x0,%xmm0,%r15
> 0x7fffe4730bc2: xor (%rdi,%r12,1),%r15
> 0x7fffe4730bc6: mov %r15,(%rsi,%r12,1)
> 0x7fffe4730bca: vpsrldq $0x8,%xmm0,%xmm0
> 0x7fffe4730bcf: add $0x8,%r12d
> ...
Glad to see this merged! @martinuy would you consider backporting this to 21? That would be helpful to my organization because we use LTS versions.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18849#issuecomment-2075857500
More information about the hotspot-compiler-dev
mailing list