RFR: 8325520: Vector loads with offsets incorrectly compiled [v4]

Damon Fenacci dfenacci at openjdk.org
Thu Apr 25 08:18:33 UTC 2024


On Mon, 22 Apr 2024 09:27:09 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - JDK-8325520: take advantage of store_Opcode to avoid more checks
>>  - JDK-8325520: remove check for offsets/mask equivalence if load->store or store->load
>>  - JDK-8325520: merge
>>  - JDK-8325520: fix missing semicolon
>>  - JDK-8325520: address PR comments
>
> test/hotspot/jtreg/compiler/vectorapi/VectorGatherMaskFoldingTest.java line 151:
> 
>> 149: 
>> 150:     @Test
>> 151:     @Warmup(10000)
> 
> Since all tests use the same warmup, I would suggest to set it once via `testFrameworkobject.setDefaultWarmup(10000)`, see https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/ir_framework/README.md

👍 thanks for the suggestion!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1579069114


More information about the hotspot-compiler-dev mailing list