RFR: 8331159: VM build without C2 fails after JDK-8180450

Vladimir Kozlov kvn at openjdk.org
Fri Apr 26 15:47:52 UTC 2024


On Thu, 25 Apr 2024 20:54:23 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:

> x86 bits are fine.

I would like author of this code to review this. @theRealAph please look.

There is difference between x64 and aarch64 how this stub is generated. For x64 it is generated as part of compiler stubs under `#ifdef COMPILER2`. For aarch64 it is in final stubs. Why is difference?

If it is really C2 specific stub then why `UseSecondarySupersTable` flag is global?

`MacroAssembler::lookup_secondary_supers_table*()` methods could be also in `c2_MacroAssembler*` files.

-------------

Changes requested by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18962#pullrequestreview-2025359590


More information about the hotspot-compiler-dev mailing list