RFR: 8330677: Add Per-Compilation memory usage to JFR [v2]

[Thomas Stuefe]

On Mon, 29 Apr 2024 10:42:34 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>>> > I read through the comments twice and did not find a nullptr related question. Which question?
>>> 
>>> See compilationMemoryStatistic.cpp .
>>> 
>>> At some places we check the result for nullptr e.g.
>>> 
>>> jdk/src/hotspot/share/compiler/compilationMemoryStatistic.cpp
>>> 
>>> Line 79 in [b3bcc49](https://github.com/openjdk/jdk/commit/b3bcc49491b8f8ad337eb4c06201a5468e5c1159)
>>> 
>>> ```
>>>  const CompileTask* const task = th->task(); 
>>> ```
>> 
>> Yes, it is inconsistent. Allmost all code here (notably anything triggered from start- or end-compilation) are called from the compiler so we run on a compiler thread and in the scope of a ciEnv. So most of the existing nullptr checks are probably not needed. 
>> 
>> We may want to make this consistent with subsequent RFEs.
>
>> We may want to make this consistent with subsequent RFEs.
> 
> I agree, this can be a follow up.

Thanks @MBaesken . For some reason your remarks only got posted now, but I think we covered all points already.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18864#issuecomment-2082423162