RFR: 8331185: Enable compiler memory limits in debug builds [v2]

[Thomas Stuefe]

On Mon, 29 Apr 2024 11:33:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'master' into compiler-default-limit
>>  - Disable memory limit for compiler/c2/TestFindNode.java until JDK-8331283 is fixed
>>  - Merge branch 'master' into compiler-default-limit
>>  - adapt tests
>>  - fix printout for mem limit
>>  - also print limit when printing compilation mem histo
>>  - default limit
>
> Opened a bug to track the memory limit break in compiler/loopopts/TestDeepGraphVerifyIterativeGVN.java. Since I cannot reproduce it, someone at Oracle should look at this:  https://bugs.openjdk.org/browse/JDK-8331295

> Thank you, @tstuefe, for filing these bugs.
> 
> One additional thing I noticed is that we don't produce compilation replay file (its size is 0) for such failures. Can you look why is that?

Yes, its https://bugs.openjdk.org/browse/JDK-8331344 . I'll post a PR shortly.

The problem behind this is more generic, namely that producing replay files needs resource area, and it shouldn't. We should not allocate resource area or heap in fatal error handling. But for now, I'll fix this locally by avoiding the recursion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18969#issuecomment-2083390670