RFR: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays [v13]

Dean Long dlong at openjdk.org
Mon Apr 29 23:05:10 UTC 2024


On Mon, 29 Apr 2024 14:33:07 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove whitespace
>
> src/hotspot/share/c1/c1_GraphBuilder.cpp line 2030:
> 
>> 2028:       receiver = state()->stack_at(index);
>> 2029:       ciType* type = receiver->exact_type();
>> 2030:       if (type != nullptr && type->is_loaded()) {
> 
> Is it the case that we can't see an interface here? Or that we think it's ok if we see an interface here?

We can't see an interface here because it will get rejected by `ciInstanceKlass::exact_klass`, so we could even assert for that here if we wanted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17667#discussion_r1583883023


More information about the hotspot-compiler-dev mailing list